Added feature to cast valid float and double string to float and doub…#1933
Merged
Fokko merged 1 commit intoapache:mainfrom Apr 18, 2025
Merged
Conversation
…le literal respectively.
Fokko
approved these changes
Apr 18, 2025
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
This looks great @guptaakashdeep Thanks for fixing this 👍
gabeiglio
pushed a commit
to Netflix/iceberg-python
that referenced
this pull request
Aug 13, 2025
Closes apache#1919 # Rationale for this change This is an additional good to have feature where users can convert valid Float and Double strings to Iceberg FloatType and Double Literal. # Are these changes tested? Yes. I have also added tests for the same. # Are there any user-facing changes? Yes. Users can cast valid float and double strings to `FloatType` and `DecimalType`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1919
Rationale for this change
This is an additional good to have feature where users can convert valid Float and Double strings to Iceberg FloatType and Double Literal.
Are these changes tested?
Yes. I have also added tests for the same.
Are there any user-facing changes?
Yes. Users can cast valid float and double strings to
FloatTypeandDecimalType